Add Counted mixin class and refactor form signature computation #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firedrake we have been running into form signature stability problems with our
Constant
s since they are implemented differently to how they are done in UFL. Specifically we need to add them torenumbering
when the form signature is calculated.I have refactored the
counted_init
part of UFL and replaced it with aCounted
mixin class. This means that we can compute the renumbering for all instances ofCounted
, rather than specifically forCoefficient
s,Constant
s etc.