Skip to content

ConstantValue: Support general dtypes#292

Merged
mscroggs merged 2 commits intoFEniCS:mainfrom
firedrakeproject:pbrubeck/fix/constant-value
Jul 20, 2024
Merged

ConstantValue: Support general dtypes#292
mscroggs merged 2 commits intoFEniCS:mainfrom
firedrakeproject:pbrubeck/fix/constant-value

Conversation

@pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Jun 6, 2024

fixes #228

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/constant-value branch 3 times, most recently from d08d747 to 9c23e57 Compare June 6, 2024 08:30
@pbrubeck
Copy link
Contributor Author

pbrubeck commented Jun 6, 2024

@mscroggs I don't understand the ruff reformating which prevents CI to pass, I thought I just needed to ruff check --fix?

@wence-
Copy link
Collaborator

wence- commented Jun 6, 2024

After ruff check --fix, run ruff format

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/constant-value branch from 9c23e57 to 1905eaa Compare June 6, 2024 08:44
@pbrubeck pbrubeck force-pushed the pbrubeck/fix/constant-value branch from 14a25e9 to 1905eaa Compare July 17, 2024 15:54
@pbrubeck
Copy link
Contributor Author

@mscroggs Could you merge this please?

@mscroggs mscroggs added this pull request to the merge queue Jul 20, 2024
Merged via the queue into FEniCS:main with commit 004a678 Jul 20, 2024
@mscroggs mscroggs deleted the pbrubeck/fix/constant-value branch July 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ufl.constantvalue.as_ufl should use the numbers hierarchy

3 participants