Fix attr-defined mypy errors
#387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnellerhase
changed the title
classes.pyattr-defined mypy errors
schnellerhase
commented
Jun 30, 2025
schnellerhase
commented
Jun 30, 2025
schnellerhase
commented
Jun 30, 2025
schnellerhase
commented
Jun 30, 2025
Remove no longer necessary `type: ignore`'s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mypy
attr-definederrors, mainly by removing automatic population of the namespaces.This also uncovered quite a few indirect
mypyerrors.There is a more complicated typing problem inside of
apply_derivatesbetween the usage ofBaseFormandExpr. This appears to require some further fixing on its own. This is currently deactivated by temporarily adding quite a fewignore's toapply_derivatives.py.Up to this ufl is then mypy compliant. We ignore no more errors on a global scope.
Fixes #386.