Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDL3 to CI and upload build artifacts #359

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

thatcosmonaut
Copy link
Member

It would be nice to figure out how to spit out a universal dylib for MacOS, but I'm not familiar enough with how that works. It would also be nice to figure out how to upload the release artifacts to the release page automatically when a release is tagged, but I'm not sure how to test that.

@flibitijibibo
Copy link
Member

In addition to macOS we also need a Rocky 8 VM for Linux builds - we should ask Misa about this.

@thatcosmonaut
Copy link
Member Author

@flibitijibibo
Copy link
Member

Oh, that looks a lot easier than what I remember... yeah, if that works with 8 then we can integrate that and the output binaries should be good to go.

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output looks okay, so the final checklist:

  • MinGW (see comment)
  • Rocky Linux 8 x86_64
  • Rocky Linux 8 aarch64

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@thatcosmonaut
Copy link
Member Author

https://github.blog/changelog/2024-09-03-github-actions-arm64-linux-and-windows-runners-are-now-generally-available/

We expect to begin offering Arm runners for open source projects by the end of the year.

Once this is enabled we can do the aarch builds. Working on the other stuff now.

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MinGW, do the Rocky tools include mingw32-cmake and mingw64-cmake? That'll help eliminate the toolchain files if so.

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes here and there for the Rocky config - if this all works then the toolchain files can be deleted. We should also chrpath -d the Linux binaries, and possibly strip -S as well (not sure why this changes the Release binaries, but it does...)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@thatcosmonaut
Copy link
Member Author

Rocky builds should be good now, it would be nice to spit out a universal MacOS dylib but I'm not gonna have time to work on that until next week at least.

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest should be good as long as macOS cooperates...

@flibitijibibo flibitijibibo merged commit 3598a33 into master Oct 18, 2024
16 checks passed
@flibitijibibo flibitijibibo deleted the ci_build_artifacts branch October 18, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants