-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDL3 to CI and upload build artifacts #359
Conversation
In addition to macOS we also need a Rocky 8 VM for Linux builds - we should ask Misa about this. |
Oh, that looks a lot easier than what I remember... yeah, if that works with 8 then we can integrate that and the output binaries should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output looks okay, so the final checklist:
- MinGW (see comment)
- Rocky Linux 8 x86_64
- Rocky Linux 8 aarch64
Once this is enabled we can do the aarch builds. Working on the other stuff now. |
0356091
to
bc14dec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For MinGW, do the Rocky tools include mingw32-cmake
and mingw64-cmake
? That'll help eliminate the toolchain files if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few fixes here and there for the Rocky config - if this all works then the toolchain files can be deleted. We should also chrpath -d
the Linux binaries, and possibly strip -S
as well (not sure why this changes the Release binaries, but it does...)
9b631bf
to
d960b54
Compare
Rocky builds should be good now, it would be nice to spit out a universal MacOS dylib but I'm not gonna have time to work on that until next week at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest should be good as long as macOS cooperates...
It would be nice to figure out how to spit out a universal dylib for MacOS, but I'm not familiar enough with how that works. It would also be nice to figure out how to upload the release artifacts to the release page automatically when a release is tagged, but I'm not sure how to test that.