zebra: V6 RA not sent anymore after interface up-down-up

[soumyar-roy]

zebra: V6 RA not sent anymore after interface up-down-up

Issue:
Once interface is shutdown, the interface is removed from
wheel timer. Now when the interface is up again, current code
won't add the interface to wheel timer again, so it won't send RA
anymore for that interface

Fix:
Moved wheel_add for interface inside rtadv_start_interface_events
This is more common function which gets triggered for both
RA enable and interface up event

Also on any kind of interface activation event, we try to send
RA as soon as possible. This is to satisfy requirement where
quick RA is needed, especially for some convergence, dependent on
RA.

Testing:
Did ineterface up to down to up
Added debug log for RA, checked it is getting advertised preodically
after when up at up state

show bgp summary for 512 bgp peers for bgp bgp unnumbered works fine.

Signed-off-by: Soumya Roy [email protected]

[mjstapp]

so ... please add a meaningful title and description?

[soumyar-roy]

so ... please add a meaningful title and description?

Added now

[ton31337]

Can you fix the comment indentation?

[soumyar-roy]

1)This comment is indented w.r.t if (!wheel->run_forever) {. before running git clang-format >>
((((curr_slot + slots_to_skip) % wheel->slots) == curr_slot) &&

•           list_isempty(wheel->wheel_slot_lists[curr_slot])) {<<<This line is tab indented
  

•           /* Came to back to same slot and that is empty
  

•            * so the wheel is empty, stop it
  

•           */
  

•           if (!wheel->run_forever) {
  

•                   wheel_stop(wheel);
  

•                   if (debug_timer_wheel)
  

•                           zlog_debug("Stopped an empty  wheel %p", wheel);
  

•                   return;
  

•           }
  

•   }
  

2)After git clang-format >>
if ((((curr_slot + slots_to_skip) % wheel->slots) == curr_slot) &&

•           list_isempty(wheel->wheel_slot_lists[curr_slot])) {
  

•       list_isempty(wheel->wheel_slot_lists[curr_slot])) {<<<<<This line gets space indented
            /* Came to back to same slot and that is empty
             * so the wheel is empty, stop it
            */
  

3. If I dont do step 2) I get style suggestion error curl https://gist.githubusercontent.com/polychaeta/13d7c1b3f9c07b87352be22b5f29ad01/raw/55bb8b7724008c107d333a05c8db9a785a2db0f7/style.diff | git apply -. So restoring back to 1)

[mjstapp]

no: line 56 is not correct. it looks like it's missing a space to align the comment block

[ton31337]

Can we have a bit of the context when fast/regular wheels are used?

[soumyar-roy]

Can we have a bit of the context when fast/regular wheels are used?

Added more context

[ton31337]

Thanks, makes sense now, but please put it inside the commit (not in PR).

[ton31337]

Why do we need this stderr print if we assert below?

[soumyar-roy]

removed.

[ton31337]

Set at least 15 seconds (this is a minimum)

[soumyar-roy]

done

[ton31337]

Shouldn't we assert here?

[soumyar-roy]

changed code.

[ton31337]

Why do you close and reopen all the time?