Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babeld: Hop Count must not be 0. #18547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

babeld: Hop Count must not be 0. #18547

wants to merge 1 commit into from

Conversation

zmw12306
Copy link
Contributor

According to RFC 8966:
Hop Count The maximum number of times that this TLV may be forwarded, plus 1. This MUST NOT be 0.
Signed-off-by: zmw12306 [email protected]

@frrbot frrbot bot added the babel label Mar 31, 2025
@zmw12306 zmw12306 mentioned this pull request Mar 31, 2025
Merged
@zmw12306
babeld: Hop Count must not be 0.
2b2bebf 
According to RFC 8966:
Hop Count The maximum number of times that this TLV may be forwarded, plus 1. This MUST NOT be 0.

Signed-off-by: zmw12306 <[email protected]>
riw777
riw777 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Apr 1, 2025

unrelated failure in ci ...

<body>
<!--StartFragment-->
31-Mar-2025 04:02:31 | Publishing an artifact: ErrorLog
-- | --
31-Mar-2025 04:02:31 | Failing as no matching files has been found and empty artifacts are not allowed.
31-Mar-2025 04:02:31 | Unable to publish artifact [ErrorLog]:

<!--EndFragment-->
</body>
</html>```

@mwinter-osr
Copy link
Member

CI:rerun Rerunning the CI after fix on [CI] Verify Source incorrectly reporting bad status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
babel master rebase PR needs rebase size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmw12306 @riw777 @mwinter-osr