Skip to content

tests: Update ospf6_ecmp_inter_area topotest (#16197 regression test, unified config) #18549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gromit1811
Copy link
Contributor

The new test_multipath_inter_area() function reliably checks for #16197 and will fail until that is fixed (the current version of the topotest only fails occasionally). Also, convert topotest to use unified config.

@frrbot frrbot bot added the tests Topotests, make check, etc label Mar 31, 2025
…ea topotest

The new test_multipath_inter_area() function reliably checks for FRRouting#16197 and
will fail until it is fixed.

Signed-off-by: Martin Buck <[email protected]>
@gromit1811 gromit1811 force-pushed the feature/topotest_ospf6_ecmp_inter_area_16197_regression_test branch from 15fc9c0 to a655607 Compare March 31, 2025 07:24
@gromit1811
Copy link
Contributor Author

In theory, ready for merging. But you might want to wait for the fix for #16197 to avoid permanent CI failures.
Replaces #16797.

@gromit1811
Copy link
Contributor Author

Does anybody know what this failure here means? https://ci1.netdef.org/browse/FRR-PULLREQ3-CHECKOUT-8369
The missing files really don't exist anymore, I'm using unified config (only frr.conf now)

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Apr 1, 2025

CI failure looks related --

 
 	{
 	    "internalNextHopActiveNum": 1,
 	    "nexthops": [
 	        {
 	            "fib": true,
 	            "interfaceName": "r1-eth2",
 	            "active": true
 	        }
 	    ]
 	}```

@gromit1811
Copy link
Contributor Author

CI failure looks related

That's good. It shows that the new test function is working as expected since the bug it's checking for is still there. The CI failure should disappear once #16197 is fixed (by #18345, which hopefully should be ready for merging in a few days).

@riw777
Copy link
Member

riw777 commented Apr 8, 2025

CI failure looks related

That's good. It shows that the new test function is working as expected since the bug it's checking for is still there. The CI failure should disappear once #16197 is fixed (by #18345, which hopefully should be ready for merging in a few days).

okay -- let me know when the other one is ready and I'll work on getting these pushed

@riw777
Copy link
Member

riw777 commented May 20, 2025

@gromit1811 any updates on the other two pr's that will clear the errors here?

@gromit1811
Copy link
Contributor Author

@gromit1811 any updates on the other two pr's that will clear the errors here?

@riw777 You just approved #18345, so once that is merged, this one here can go in as well. AFAIK, there's no other PR this one depends on, #16197 was just the bug report that started everything and that will be fixed by merging #18345.

@riw777
Copy link
Member

riw777 commented Jun 17, 2025

ci:rerun

@gromit1811 gromit1811 mentioned this pull request Jun 18, 2025
7 tasks
@gromit1811
Copy link
Contributor Author

The "Basic Tests" failure looks unrelated - this PR doesn't touch BGP at all. And the "Test ubuntu ARM docker image" failure looks like a stale error. The test didn't actually run after #18345 was merged - logs are from March 31.

@riw777
Copy link
Member

riw777 commented Jul 1, 2025

ci:rerun

@riw777
Copy link
Member

riw777 commented Jul 15, 2025

ci:rerun ...

logs from the last run expired, need to rerun to figure out what's going on

@gromit1811
Copy link
Contributor Author

Again, looks like nothing related to this PR. I don't see how the changes here could possibly break bgp_addpath_best_selected. And the failing ARM docker image build has been failing forever and a "ci:rerun" doesn't seem to trigger a new build. Last time I saw this elsewhere, this was due to a broken ARM Debian package mirror.

@riw777
Copy link
Member

riw777 commented Jul 22, 2025

ci:rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master size/XL tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants