Apply record component annotations to getter methods and canonical constructor parameters #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructor parameters
modmuss50
approved these changes
Oct 15, 2025
|
Tests might be nice, but ill leave that up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the anonymous classes in the apply visitor to named inner classes to reduce nesting.
When the class is a record, it now reads all methods into
MethodNodes and applies them insidevisitEnd(), because record components as per the ASM docs are not guaranteed to be visited before methods (even though in practice they are byClassReader.acceptandClassNode.accept).