Add annotations apply integration test #1396
Merged
+110
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Oct 16, 2025
Comment on lines
+5
to
+9
| dependencies { | ||
| minecraft "com.mojang:minecraft:25w42a" | ||
| mappings "net.fabricmc:yarn:25w42a+build.9:v2" | ||
| modImplementation "net.fabricmc:fabric-loader:0.17.3" | ||
| } |
There was a problem hiding this comment.
For a test as simple as this just use the minimalBase project, and have a look at how the other tests use it, you can just move this dependencies block into the groovy test code. It doesnt look like you have a reason to have actual mod code for this test.
There was a problem hiding this comment.
Without mod code, :compileJava would be skipped, and I noticed it wasn't generating the Minecraft jar
There was a problem hiding this comment.
Uhh, that shouldnt be the case (I wish it was) 🤔 Happy to go with this its not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration test for applying annotations in mappings, based on the annotation that is published in yarn at the moment. We can add more test cases when more annotations are added in yarn.