Skip to content

Conversation

@modmuss50
Copy link
Member

This is a large source of random errors we see in the support channels.

This is a large source of random errors we see in the support channels.
@modmuss50 modmuss50 requested a review from Copilot October 23, 2025 20:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning system to detect when a Fabric Loom project is stored in a OneDrive directory on Windows, which is known to cause performance issues and random errors.

  • Introduces a new OneDrive utility class to detect OneDrive locations via environment variables
  • Integrates OneDrive detection into the Loom plugin initialization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/java/net/fabricmc/loom/util/OneDrive.java New utility class that checks if a project is located in OneDrive by reading OneDrive-related environment variables and comparing paths
src/main/java/net/fabricmc/loom/LoomGradlePlugin.java Integrates OneDrive verification into plugin initialization by calling OneDrive.verify()

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@modmuss50 modmuss50 merged commit c08bfbe into FabricMC:exp/1.12 Oct 23, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant