Fix: State when losing connection #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing our firmware I ran into many times that when losing connection the ppp_run loop skips the "wait_operation_state(DataEstablished)" because the operation state never got changed when we lost connection.
The cell_device in device_fut is waiting for registration to change but when I tested it the ppp_run looped around before the device got the registration change.
I fixed this by setting desired state to initialized once we exit the embassy-net-ppp run.
I also added a drop implementation for this, as in cases where the select breaks we still wants to set the states.