Skip to content

Bump playwright from 1.51.0 to 1.51.1 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 24, 2025

Bumps playwright from 1.51.0 to 1.51.1.

Release notes

Sourced from playwright's releases.

v1.51.1

Highlights

microsoft/playwright#35093 - [Regression]: TimeoutOverflowWarning: 2149630296.634 does not fit into a 32-bit signed integer microsoft/playwright#35138 - [Regression]: TypeError: Cannot read properties of undefined (reading 'expectInfo')

Browser Versions

  • Chromium 134.0.6998.35
  • Mozilla Firefox 135.0
  • WebKit 18.4

This version was also tested against the following stable channels:

  • Google Chrome 133
  • Microsoft Edge 133
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [playwright](https://github.com/microsoft/playwright) from 1.51.0 to 1.51.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.51.0...v1.51.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Mar 24, 2025
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-graph ❌ Failed (Inspect) Mar 24, 2025 2:33am

Copy link
Contributor

coderabbitai bot commented Mar 24, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

qodo-merge-pro bot commented Mar 24, 2025

CI Feedback 🧐

(Feedback updated until commit f90a077)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: test

Failed stage: Set up environment variables and run tests [❌]

Failure summary:

The action failed due to a TypeScript type error in the file e2e/logic/POM/codeGraph.ts at line 272.
The error occurs in the clickCreateNewProjectBtn() method where there's a type mismatch between
different versions of Playwright's Locator types:

  • The waitForElementToBeVisible function expects a Locator from one version of Playwright
  • But this.createNewProjectBtn is a Locator from a different version (likely from a different package
    path)

    Specifically, there's an incompatibility between types from /playwright-core/types/types and
    /@playwright/test/node_modules/playwright-core/types/types, causing type errors with the
    ElementHandle objects.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    1529:  68:8  Warning: React Hook useEffect has missing dependencies: 'handleSetSelectedPath' and 'paths'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
    1530:  84:8  Warning: React Hook useEffect has a missing dependency: 'handleSubmit'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
    1531:  91:8  Warning: React Hook useEffect has missing dependencies: 'setIsPathResponse', 'setPaths', and 'setSelectedPath'. Either include them or remove the dependency array. If 'setIsPathResponse' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps
    1532:  ./app/components/code-graph.tsx
    1533:  88:8  Warning: React Hook useEffect has missing dependencies: 'graph.Elements' and 'setData'. Either include them or remove the dependency array. If 'setData' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps
    1534:  93:8  Warning: React Hook useEffect has a missing dependency: 'handleSelectedValue'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
    1535:  108:8  Warning: React Hook useEffect has a missing dependency: 'handleRemove'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
    1536:  163:8  Warning: React Hook useEffect has a missing dependency: 'fetchCount'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
    1537:  ./app/components/combobox.tsx
    1538:  38:8  Warning: React Hook useEffect has a missing dependency: 'fetchOptions'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
    1539:  50:8  Warning: React Hook useEffect has missing dependencies: 'fetchOptions' and 'lastOpened'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
    1540:  ./app/components/graphView.tsx
    1541:  105:8  Warning: React Hook useEffect has a missing dependency: 'setCooldownTicks'. Either include it or remove the dependency array. If 'setCooldownTicks' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps
    1542:  105:19  Warning: React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked.  react-hooks/exhaustive-deps
    1543:  info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/app/api-reference/config/eslint#disabling-rules
    1544:  Failed to compile.
    1545:  ./e2e/logic/POM/codeGraph.ts:272:59
    1546:  Type error: Argument of type 'import("/home/runner/work/code-graph/code-graph/node_modules/playwright-core/types/types").Locator' is not assignable to parameter of type 'import("/home/runner/work/code-graph/code-graph/node_modules/@playwright/test/node_modules/playwright-core/types/types").Locator'.
    1547:  The types returned by 'evaluateHandle(...)' are incompatible between these types.
    ...
    
    1551:  Type 'Promise<ElementHandleForTag<any> | null>' is not assignable to type 'Promise<ElementHandle<HTMLElement | SVGElement> | null>'.
    1552:  Type 'ElementHandleForTag<any> | null' is not assignable to type 'ElementHandle<HTMLElement | SVGElement> | null'.
    1553:  Type 'ElementHandleForTag<any>' is not assignable to type 'ElementHandle<HTMLElement | SVGElement>'.
    1554:  Types of property 'waitForSelector' are incompatible.
    1555:  Type '{ <K extends keyof HTMLElementTagNameMap>(selector: K, options?: ElementHandleWaitForSelectorOptionsNotHidden | undefined): Promise<import("/home/runner/work/code-graph/code-graph/node_modules/playwright-core/types/structs").ElementHandleForTag<...>>; (selector: string, options?: ElementHandleWaitForSelectorOptionsN...' is not assignable to type '{ <K extends keyof HTMLElementTagNameMap>(selector: K, options?: ElementHandleWaitForSelectorOptionsNotHidden | undefined): Promise<import("/home/runner/work/code-graph/code-graph/node_modules/@playwright/test/node_modules/playwright-core/types/structs").ElementHandleForTag<...>>; (selector: string, options?: Elemen...'.
    1556:  Types of parameters 'options' and 'options' are incompatible.
    1557:  Type 'ElementHandleWaitForSelectorOptions' is not assignable to type 'ElementHandleWaitForSelectorOptionsNotHidden'.
    1558:  Type 'ElementHandleWaitForSelectorOptions' is not assignable to type '{ state?: "visible" | "attached" | undefined; }'.
    1559:  Types of property 'state' are incompatible.
    1560:  Type '"visible" | "hidden" | "attached" | "detached" | undefined' is not assignable to type '"visible" | "attached" | undefined'.
    1561:  Type '"hidden"' is not assignable to type '"visible" | "attached" | undefined'.
    1562:  �[0m �[90m 270 |�[39m�[0m
    1563:  �[0m �[90m 271 |�[39m     �[36masync�[39m clickCreateNewProjectBtn()�[33m:�[39m �[33mPromise�[39m�[33m<�[39m�[36mvoid�[39m�[33m>�[39m {�[0m
    1564:  �[0m�[31m�[1m>�[22m�[39m�[90m 272 |�[39m         �[36mconst�[39m isVisible �[33m=�[39m �[36mawait�[39m waitForElementToBeVisible(�[36mthis�[39m�[33m.�[39mcreateNewProjectBtn)�[33m;�[39m�[0m
    1565:  �[0m �[90m     |�[39m                                                           �[31m�[1m^�[22m�[39m�[0m
    1566:  �[0m �[90m 273 |�[39m         �[36mif�[39m (�[33m!�[39misVisible) �[36mthrow�[39m �[36mnew�[39m �[33mError�[39m(�[32m"'Create New Project' button is not visible!"�[39m)�[33m;�[39m�[0m
    1567:  �[0m �[90m 274 |�[39m         �[36mawait�[39m �[36mthis�[39m�[33m.�[39mcreateNewProjectBtn�[33m.�[39mclick()�[33m;�[39m�[0m
    1568:  �[0m �[90m 275 |�[39m     }�[0m
    1569:  Next.js build worker exited with code: 1 and signal: null
    1570:  ##[error]Process completed with exit code 1.
    1571:  ##[group]Run actions/upload-artifact@v4
    1572:  with:
    1573:  name: playwright-report
    1574:  path: playwright-report/
    1575:  retention-days: 30
    1576:  if-no-files-found: warn
    1577:  compression-level: 6
    1578:  overwrite: false
    1579:  include-hidden-files: false
    1580:  ##[endgroup]
    1581:  ##[warning]No files were found with the provided path: playwright-report/. No artifacts will be uploaded.
    1582:  ##[group]Run actions/upload-artifact@v4
    1583:  with:
    1584:  name: failed-test-screenshots
    1585:  path: playwright-report/artifacts/
    ...
    
    1592:  ##[warning]No files were found with the provided path: playwright-report/artifacts/. No artifacts will be uploaded.
    1593:  Post job cleanup.
    1594:  [command]/usr/bin/git version
    1595:  git version 2.48.1
    1596:  Temporarily overriding HOME='/home/runner/work/_temp/306422c6-edd3-4898-ba7a-64df34fa3a59' before making global git config changes
    1597:  Adding repository directory to the temporary git global config as a safe directory
    1598:  [command]/usr/bin/git config --global --add safe.directory /home/runner/work/code-graph/code-graph
    1599:  [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
    1600:  [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
    1601:  [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
    1602:  http.https://github.com/.extraheader
    1603:  [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
    1604:  [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
    1605:  Print service container logs: b8c441dfbb0c4ce4b141e1e372527e24_falkordbfalkordblatest_b48ced
    1606:  ##[command]/usr/bin/docker logs --details 40141e7abded9861b47db1d2719ffa0026bac3dd9696442e69bf5154fb081d02
    1607:  11:C 24 Mar 2025 02:33:09.003 # WARNING Memory overcommit must be enabled! Without it, a background save or replication may fail under low memory condition. Being disabled, it can also cause failures without low memory condition, see https://github.com/jemalloc/jemalloc/issues/1328. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
    1608:  11:C 24 Mar 2025 02:33:09.004 * oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
    

    Copy link
    Contributor Author

    dependabot bot commented on behalf of github Mar 26, 2025

    OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

    If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

    @dependabot dependabot bot deleted the dependabot/npm_and_yarn/staging/playwright-1.51.1 branch March 26, 2025 11:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant