Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Macos-13 runner #582

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Nov 28, 2024

  • Update to Python 3.9+
  • Update to use Macos 13 action runners as MacOS 12 is deprecated and no longer supported on 3rd Dec 2024
  • Updated SDL2 to 2.24.2 as 2.0.16 have deprecated code that xcode 14 / 15 would raise an error (this is required due to macos 13) - macOS: Build failure with Clang 14. libsdl-org/SDL#5846

For future explorers, when vcpkg says CMAKE_CXX_COMPILER not found, this is not true, rather one of the packages has failed so actually print the subpackage install logs and see where one has an error. You will probably need to update your subpackage version or the upstream repo itself.

FYI https://github.com/actions/runner-images Macos 13 is the x86 runner and macos14 is the arm64 runner

@pseudo-rnd-thoughts
Copy link
Member Author

pseudo-rnd-thoughts commented Jan 8, 2025

Lesson to learn, read the logs and the log files if given very carefullly, don't just scroll to the bottom

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 6b57d42 into Farama-Foundation:master Jan 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant