Add features x11, wayland and alsa to sdl #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unexploredtest Thanks for the PR. Do you want to add #588 fix here? |
|
Yeah will add shortly |
unexploredtest
changed the title
|
@pseudo-rnd-thoughts Fix added |
pseudo-rnd-thoughts
approved these changes
Jul 12, 2025
pseudo-rnd-thoughts
merged commit 84f3fad
into
Farama-Foundation:master
33 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit fa48461, the sdl version was upgraded from
2.24.2to2.30.11in vcpkg. From what I understood, in older versions even if you disable default features, SDL would be built with x11 anyways (?) however that changed since version2.26.2in vcpkg and not using default features resulted in neither building with x11 nor with wayland support, which results in having the no display issue.Here we explicitly specify to use features x11 and wayland, which fixes the issue. We don't enable default features as that includes
ibusanddbuswhich aren't necessary and cause build issues anyways.Fixes #625.
Also sdl was never built with audio support on Linux, which we enable the feature
alsafor the audio to work.Partially fixes #588. (Only solves Linux's issue)