Skip to content

[Proposal] Default metadata in BaseMujocoEnv #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Proposal] Default metadata in BaseMujocoEnv #1099

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3f98a98
proposed change to mujocoenv as per issue 1059
spiglerg Jun 29, 2024
84bb681
proposed change to mujocoenv as per issue 1059
spiglerg Jun 29, 2024
bdc6f9b
fixed assert for render_fps in mujocoenv
spiglerg Jul 16, 2024
d8f4c48
Merge branch 'Farama-Foundation:main' into main
spiglerg Jul 16, 2024
de75373
precommit tests
spiglerg Jul 21, 2024
53a4b15
Merge branch 'Farama-Foundation:main' into main
spiglerg Jul 21, 2024
0d3ba9f
fixed bug with overriding class variable 'metadata'
spiglerg Jul 22, 2024
4b09aae
updates to metadata in mujocoenv
spiglerg Jul 24, 2024
dac810b
minor fix
spiglerg Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions gymnasium/envs/mujoco/mujoco_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ def __init__(

self.frame_skip = frame_skip

assert self.metadata["render_modes"] == [
"human",
"rgb_array",
"depth_array",
], self.metadata["render_modes"]
if "render_fps" in self.metadata:
assert (
int(np.round(1.0 / self.dt)) == self.metadata["render_fps"]
), f'Expected value: {int(np.round(1.0 / self.dt))}, Actual value: {self.metadata["render_fps"]}'
self.metadata = {
"render_modes": [
"human",
"rgb_array",
"depth_array",
],
"render_fps": int(np.round(1.0 / self.dt)),
}

if observation_space is not None:
self.observation_space = observation_space
self._set_action_space()
Expand Down