Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for the RGBImgPartialObsWrapper view size issue #421

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vishwassathish
Copy link

@vishwassathish vishwassathish commented Feb 25, 2024

Description

As reported in the bug, the RGBImgPartialObsWrapper ignored changes to agent_view_size parameter when rendering an RGB image. The issue was replicated and it was found that env.agent_view_size and env.unwrapped.agent_view_size had different values after applying a view size wrapper ViewSizeWrapper(env, agent_view_size=5).

Fixes # (issue)

Made a small change to the RGBImgPartialObsWrapper method in wrappers.py by adding an agent_view_size parameter. Also passed this argument to get_pov_render() and gen_obs_grid() functions in minigrid_env.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.
output_before
output_after

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vishwassathish vishwassathish changed the title Bug Fix for the issue https://github.com/Farama-Foundation/Minigrid/issues/419 Bug Fix for the issue (here)[https://github.com/Farama-Foundation/Minigrid/issues/419] Feb 25, 2024
@vishwassathish vishwassathish changed the title Bug Fix for the issue (here)[https://github.com/Farama-Foundation/Minigrid/issues/419] Bug Fix for the RGBImgPartialObsWrapper view size issue [https://github.com/Farama-Foundation/Minigrid/issues/419] Feb 25, 2024
@vishwassathish vishwassathish changed the title Bug Fix for the RGBImgPartialObsWrapper view size issue [https://github.com/Farama-Foundation/Minigrid/issues/419] Bug Fix for the RGBImgPartialObsWrapper view size issue Feb 25, 2024
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants