Add scaling for PositionBonus #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-rnd-thoughts
approved these changes
Jan 13, 2025
Member
pseudo-rnd-thoughts
left a comment
pseudo-rnd-thoughts
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good
pseudo-rnd-thoughts
merged commit 8710e91
into
Farama-Foundation:master
7 checks passed
Martin36
pushed a commit
to Martin36/Minigrid
that referenced
this pull request
Oct 15, 2025
Co-authored-by: Mark Towers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very simple improvement to the PositionBonus wrapper, which adds the ability to scale the added bonus.
Type of change
I didn't do any of the checks, but based on the simplicity of this PR, I don't believe anything should be broken or otherwise changed.