Skip to content

Conversation

@BolunDai0216
Copy link
Collaborator

@BolunDai0216 BolunDai0216 commented Oct 22, 2024

Description

This PR updates Minigrid to support Gymnasium 1.0.0 and NumPy 2.0 (tested with 2.1.2).

Fixes #452

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you update the version number and doctest seems to be failing because of NumPy 2.0 changed the format for some reason

@BolunDai0216 BolunDai0216 merged commit 0dba116 into Farama-Foundation:master Nov 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] gymnasium.error.NameNotFound: Environment BabyAI_GoToObjS6 doesn't exist.

2 participants