Skip to content

Floating dates: make telegram like days animation & other refactoring for performance improvement and easier maintaining #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 12, 2025

Conversation

kesha-antonov
Copy link
Collaborator

@kesha-antonov kesha-antonov commented Feb 11, 2025

  • Added smooth fade in/out of date while scrolling
  • Made date appear on scroll to date between messages
  • Added FlashList instead of FlatList
  • Updated all deps
  • Refactored few class components to functional components
  • Refactored style usage to use common styles from 1 file
  • Removed flow & prop-types since we have typescript and prop-types is deprecated and flow is not widely used
1.mp4

@kesha-antonov kesha-antonov changed the title Floating dates: make telegram like days animation Floating dates: make telegram like days animation and other refactoring for performance & easier maintaining Feb 12, 2025
@kesha-antonov kesha-antonov changed the title Floating dates: make telegram like days animation and other refactoring for performance & easier maintaining Floating dates: make telegram like days animation & other refactoring for performance and easier maintaining Feb 12, 2025
@kesha-antonov kesha-antonov changed the title Floating dates: make telegram like days animation & other refactoring for performance and easier maintaining Floating dates: make telegram like days animation & other refactoring for performance improvement and easier maintaining Feb 12, 2025
@kesha-antonov kesha-antonov merged commit 622e1a9 into master Feb 12, 2025
2 checks passed
@Randall71
Copy link

Hi @kesha-antonov , thanks for keeping this library up to date.

I saw that you replaced the use of FlatList with FlashList, wouldn't it be interesting to allow to add a list as a property that will be used? So for example, we can switch according to expectations, especially since we now have legend-list

What do you think about it?

@kesha-antonov
Copy link
Collaborator Author

Hi @kesha-antonov , thanks for keeping this library up to date.

I saw that you replaced the use of FlatList with FlashList, wouldn't it be interesting to allow to add a list as a property that will be used? So for example, we can switch according to expectations, especially since we now have legend-list

What do you think about it?

Hi
Depends on community demands

@iM-GeeKy
Copy link

@kesha-antonov Is there a way to add styles to the floating date that was introduced?

@TowhidKashem
Copy link

Hi @kesha-antonov , thanks for keeping this library up to date.
I saw that you replaced the use of FlatList with FlashList, wouldn't it be interesting to allow to add a list as a property that will be used? So for example, we can switch according to expectations, especially since we now have legend-list
What do you think about it?

Hi Depends on community demands

I think this is a good idea, I was wondering the same, exposing a prop is what a lot of libs do in this type of scenario and is the most flexible. Personally I started to notice some issues with gifted chat recently and came in here looking for what might have changed. My personal experience with trying to roll my own flashlist based chat implementation was to end up using flatlist at the end cause visualization lead to a huge number of issues. So I'm kind of surprised this was merged as a minor change rather than a major one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants