Skip to content

Conversation

@JooHyukKim
Copy link
Member

No description provided.

*<p>
* Note that actual type of 'context' is
* <code>com.fasterxml.jackson.databind.SerializerProvider</code>,
* <code>SerializerProvider</code>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be

<code>SerializerProvider</code> (2.x) / <code>SerializationContext</code> (3.x)

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed, almost there. :)

@JooHyukKim
Copy link
Member Author

Thank you again!
I would try to go over the project if there is anything else to change.

*<p>
* Note that actual type of 'context' is
* <code>com.fasterxml.jackson.databind.SerializerProvider</code>,
* Should probably be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, did not mean for "Should probably be" added, just remove that line.

@JooHyukKim JooHyukKim marked this pull request as draft December 31, 2025 18:29
@JooHyukKim
Copy link
Member Author

@cowtowncoder I will come back with more changes wrt renaming

@JooHyukKim JooHyukKim marked this pull request as ready for review December 31, 2025 18:44
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowtowncoder cowtowncoder merged commit de02dfb into FasterXML:2.x Dec 31, 2025
4 checks passed
@JooHyukKim JooHyukKim deleted the update-readme branch December 31, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants