Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Fix #887: use module-info.java directly #888

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

cowtowncoder
Copy link
Member

So, fix #887 by adding 2 module-info.javas like for other modules.

@cowtowncoder
Copy link
Member Author

Not quite working yet: seems like build is working, but test build has an issue: odd failure

[ERROR] Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.9.25:test-compile (test-compile) on project jackson-module-kotlin: Compilation failure
[ERROR] Module junit cannot be found in the module graph

given that junit is for JUnit 4 which is not used by Kotlin module (JUnit 5, jupiter, is).

Hopefully can figure it out and this is done.

@cowtowncoder
Copy link
Member Author

Ok. So, no matter what I do, it looks like only "regular" module-info.java from src/main/java/ takes effect: one from src/test/java (for tests not so much). All the instructions I have seen suggest adding it under java dirs (not kotlin). I have tried adding source directory config for Maven plug-ins and all, in vain. Almost ready to give up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant