Skip to content

Feature/settings #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Feature/settings #195

merged 6 commits into from
Feb 22, 2021

Conversation

AckslD
Copy link
Collaborator

@AckslD AckslD commented Feb 19, 2021

What this PR does:

Show correct profile setting screen depending user is signed in or not.

Which issue(s) this PR fixes:

Fixes #190

Additional comments:
My first PR, happy to hear any feedback so don't hesitate to point out whatever you see :)

@todo
Copy link

todo bot commented Feb 19, 2021

() }

setupNotificationSettingsContainer.setOnClickListener { TODO() }
myAccountContainer.setOnClickListener {
findNavController().navigate(com.fightpandemics.R.id.action_indivProfileSettings_to_nav_splash_onboard)
}
aboutUsContainer.setOnClickListener { openWebView(URLs.ABOUT_US) }
privacyPolicyContainer.setOnClickListener { openWebView(URLs.PRIVACY_POLICY) }


This comment was generated by todo based on a TODO comment in ee2ce7c in #195. cc @FightPandemics.

@todo
Copy link

todo bot commented Feb 19, 2021

() }

feedbackContainer.setOnClickListener { TODO() }
signoutContainer.setOnClickListener { TODO() }
}
private fun hideSignedInViews() {
var views: Array<View> = arrayOf(


This comment was generated by todo based on a TODO comment in ee2ce7c in #195. cc @FightPandemics.

@todo
Copy link

todo bot commented Feb 19, 2021

() }

signoutContainer.setOnClickListener { TODO() }
}
private fun hideSignedInViews() {
var views: Array<View> = arrayOf(
updatePublicProfileContainer,


This comment was generated by todo based on a TODO comment in ee2ce7c in #195. cc @FightPandemics.

@AckslD AckslD requested review from carl05 and jaliquiel February 19, 2021 20:24
Copy link
Collaborator

@jaliquiel jaliquiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry I don't have any feedback besides that I think it looks very good! I really liked how you organized your code and named your functions!

@carl05 carl05 merged commit 73f86e6 into development Feb 22, 2021
@todo todo bot mentioned this pull request Feb 22, 2021
@carl05 carl05 deleted the feature/settings branch February 22, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings screen when user is not logged in
3 participants