fix: Prevent an error if no sticky search button is used. #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subs.ft.com heavily modifies the header. It uses a sticky header without search interface. Generally we don't support this level of customisation for components, and would expect things could break in minor/patch releases without notice. I'd have recommended creating a custom component here from scratch. We might want to consider an Origami header component that centres a logo and allows for custom items left/right, but it's unlikely to make it on our roadmap soon. https://origami.ft.com/getting-started/customisation/ Despite that, this is a small issue, so let us be helpful and check for the presence of search and fail gracefully. We have recommended to pin to the patch release to reduce risk of future changes breaking unsupported customisations.
notlee
commented
Mar 27, 2025
| const searchIcon = headerEl.querySelector( | ||
| `[aria-controls="${stickyHeaderId.slice(1)}"]` | ||
| ); | ||
| const isHeaderExpanded = stickyHeaderContainer |
There was a problem hiding this comment.
Prettier. This is a one line change, here. isHeaderExpanded is false if stickyHeaderContainer is not found.
frshwtr
reviewed
Apr 1, 2025
| </div> | ||
| </div> | ||
| ); | ||
| return <></>; |
There was a problem hiding this comment.
Should all of this been removed?
|
@notlee is this still needed? 😅 |
|
@j-mes Yeah, in that it's more resilient, but no one is waiting on it. Thanks for the reminder. I'm probably not going to get to this before leaving so feel free to pick up or close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subs.ft.com heavily modifies the header. It uses a sticky header without search interface.
Generally we don't support this level of customisation for components, and would expect things could break in minor/patch releases without notice. I'd have recommended creating a custom component here from scratch. We might want to consider an Origami header component that centres a logo and allows for custom items left/right, but it's unlikely to make it on our roadmap soon. https://origami.ft.com/getting-started/customisation/
Despite that, this is a small issue, so let us be helpful and check for the presence of search and fail gracefully. We have recommended to pin to the patch release to reduce risk of future changes breaking unsupported customisations.
Closes: #2050