Open
Conversation
Incomplete. Mostly would like more definition on what functions are supposed to do and whats valid and invalid inputs. Also see room for refactoring to break up the longer tests.
Lesson learned: Stat will return a ErrExist error
Some failing tests will be fixed with next commit
Important to note the change where we MkdirAll before we zip. If output dir doesnt exist, code fails
This is useful for: 1. Cleaning up after tests and 2. Returning to caller so that they can invoke an \"open after unzip\" or similiar functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.