Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ActionsTests improvements #4

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

Dor-bl
Copy link
Contributor

@Dor-bl Dor-bl commented Mar 31, 2024

Added SetUp and TearDown Attributes
Moved the active element text one step earlier for easier debugging

Copy link
Collaborator

@aristotelos aristotelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, thanks for the contribution!

src/FlaUI.WebDriver.UITests/ActionsTest.cs Outdated Show resolved Hide resolved
src/FlaUI.WebDriver.UITests/ActionsTest.cs Outdated Show resolved Hide resolved
@Dor-bl Dor-bl requested a review from aristotelos April 6, 2024 17:58
Copy link
Collaborator

@aristotelos aristotelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of _driver on line 12 and driver on line 18 won't build...

@Dor-bl
Copy link
Contributor Author

Dor-bl commented Apr 8, 2024

The use of _driver on line 12 and driver on line 18 won't build...

Right..wasn't paying attention

@Dor-bl
Copy link
Contributor Author

Dor-bl commented Apr 9, 2024

@aristotelos fixed

@Dor-bl Dor-bl requested a review from aristotelos April 9, 2024 20:10
@aristotelos aristotelos merged commit 583d2bf into FlaUI:main Apr 10, 2024
1 check passed
@Dor-bl Dor-bl deleted the Actions_test branch April 10, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants