-
Notifications
You must be signed in to change notification settings - Fork 113
Fix argsort datatype bug #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
int 8类型也有类似错误。使用下述补丁修复,无问题:
|
Feiyu implemented functions get_dtype_max and get_dtype_min in file limits.py and I think you could consider reusing them. |
yes, I reuse it to simplify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
对于padding的值我们会根据 desecend 参数给pad 当前输入数据类型的最大值 or 最小值。
#505
在原issue的case输入是int64,而后续kernel内部转成int32,导致问题
修复后结果正常: