Skip to content

[test] relax the accuracy condition of log op #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

[test] relax the accuracy condition of log op #534

merged 1 commit into from
Apr 14, 2025

Conversation

StrongSpoon
Copy link
Collaborator

PR Category

OP Test

Type of Change

Other

Description

asserting results equal is not appropriate for cpu mode.
this pr sets reference input tensor as higher precision and only requires output tensors to be close.

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

Copy link
Collaborator

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StrongSpoon StrongSpoon merged commit 07cd92f into master Apr 14, 2025
11 of 12 checks passed
@StrongSpoon StrongSpoon deleted the log branch April 14, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants