Skip to content

[AdvancedCompiler] Add index_put_ #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 24, 2025

Conversation

AdvancedCompiler
Copy link
Contributor

PR Category

Operator

Type of Change

New Feature

Description

Implement the function of index_put_ op

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

image

@0x45f
Copy link
Collaborator

0x45f commented Apr 14, 2025

It is recommended to implement the inplace kernel in the index_put.py file and reuse the previous index_put code.

@0x45f 0x45f self-assigned this Apr 15, 2025
@AdvancedCompiler
Copy link
Contributor Author

It is recommended to implement the inplace kernel in the index_put.py file and reuse the previous index_put code.

The code has been modified as required.

@@ -318,6 +318,21 @@ def inner(shapes, dtype, device):
return inner


def index_put__input_fn(accumulate):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse index_put_input_fn?

Copy link
Collaborator

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdvancedCompiler AdvancedCompiler changed the title Add_index_put_ [AdvancedCompiler] Add index_put_ Apr 23, 2025
@0x45f 0x45f merged commit 09edfdd into FlagOpen:master Apr 24, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants