Skip to content

Patch vllm FlashAttentionImpl forward #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 14, 2025
Merged

Patch vllm FlashAttentionImpl forward #757

merged 6 commits into from
Jul 14, 2025

Conversation

0x45f
Copy link
Collaborator

@0x45f 0x45f commented Jul 9, 2025 •
edited
Loading

PR Category

Operator

Type of Change

New Feature

Description

Patch vllm FlashAttentionImpl forward

TODO:

  • support FP8
  • support cascade_attention

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@0x45f 0x45f marked this pull request as ready for review July 14, 2025 07:25
@StrongSpoon StrongSpoon self-assigned this Jul 14, 2025
StrongSpoon
StrongSpoon approved these changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@StrongSpoon StrongSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StrongSpoon StrongSpoon merged commit e23ed53 into FlagOpen:master Jul 14, 2025
11 of 13 checks passed
@0x45f 0x45f deleted the patch-vllm-FlashAttentionImpl-forward branch July 14, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrongSpoon StrongSpoon StrongSpoon approved these changes

Assignees

@StrongSpoon StrongSpoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x45f @StrongSpoon