Fill(cpp wrapper) #800
Merged
Fill(cpp wrapper) #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclementine
reviewed
Jul 17, 2025
src/flag_gems/csrc/cstub.cpp
Outdated
| m.def("fill_scalar(Tensor input, const Scalar& value) -> Tensor"); | ||
| m.def("fill_tensor(Tensor input, const Tensor& value) -> Tensor"); | ||
| m.def("fill_scalar_(Tensor! input, const Scalar& value) -> Tensor!"); | ||
| m.def("fill_tensor_(Tensor! input, const Tensor& value) -> Tensor!"); |
There was a problem hiding this comment.
The schemas here do not need to include const Scalar&, just Scalar is fine. but the function signatures do.
There was a problem hiding this comment.
Thanks for the review，I've applied the suggested changes
iclementine
reviewed
Jul 17, 2025
lib/fill.cpp
Outdated
| namespace flag_gems { | ||
| using namespace triton_jit; | ||
|
|
||
| at::Tensor fill_scalar(const at::Tensor& input, const c10::Scalar value) { |
There was a problem hiding this comment.
Use const c10::Scalar&.
There was a problem hiding this comment.
Thanks for the review，I've applied the suggested changes
iclementine
reviewed
Jul 17, 2025
include/flag_gems/operators.h
Outdated
|
|
||
| at::Tensor fill_tensor(const at::Tensor &input, const at::Tensor &value); | ||
|
|
||
| void fill_scalar_(at::Tensor &input, const c10::Scalar value); |
There was a problem hiding this comment.
Use const c10::Scalar&
There was a problem hiding this comment.
Thanks for the review，I've applied the suggested changes
iclementine
reviewed
Jul 17, 2025
lib/fill.cpp
Outdated
| return out; | ||
| } | ||
|
|
||
| void fill_scalar_(at::Tensor& input, const c10::Scalar value) { |
There was a problem hiding this comment.
Use const c10::Scalar&
There was a problem hiding this comment.
Thanks for the review，I've applied the suggested changes
iclementine
previously approved these changes
Jul 17, 2025
StrongSpoon
approved these changes
Jul 17, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
CPP wrapper packaging for fill op.
Issue
Progress
Performance