-
Notifications
You must be signed in to change notification settings - Fork 449
feat: enable feature versioning for new environments #5108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable feature versioning for new environments #5108
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Uffizzi Ephemeral Environment
|
…-default-for-new-environments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5108 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1255 1255
Lines 44317 44349 +32
=======================================
+ Hits 43331 43363 +32
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-default-for-new-environments
668c9bc
to
5ae9249
Compare
Ok, I think this PR is ready for review now @khvn26 . I've made a few simplifications and I think it's a lot clearer now what the purpose of the PR is. I've removed some of the code which was resolving unrelated bad test code to another PR, and created a separate issue in the flagsmith-python-client repository to handle improving our testing capabilities. |
Docker builds report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
Changes
Enable feature versioning for environments in newly created projects (based on a flag).
How did you test this code?
Added unit tests.