Skip to content

feat: enable feature versioning for new environments #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 14, 2025

Changes

Enable feature versioning for environments in newly created projects (based on a flag).

How did you test this code?

Added unit tests.

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 11:32am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 11:32am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 11:32am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Uffizzi Ephemeral Environment deployment-60945

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5108

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (a6a5b06) to head (5ae9249).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5108   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1255     1255           
  Lines       44317    44349   +32     
=======================================
+ Hits        43331    43363   +32     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 17, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 23, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
@matthewelwell matthewelwell force-pushed the feat/enable-feature-versioning-by-default-for-new-environments branch from 668c9bc to 5ae9249 Compare July 8, 2025 11:32
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
@matthewelwell
Copy link
Contributor Author

Ok, I think this PR is ready for review now @khvn26 .

I've made a few simplifications and I think it's a lot clearer now what the purpose of the PR is. I've removed some of the code which was resolving unrelated bad test code to another PR, and created a separate issue in the flagsmith-python-client repository to handle improving our testing capabilities.

@matthewelwell matthewelwell marked this pull request as ready for review July 8, 2025 11:34
@matthewelwell matthewelwell requested a review from a team as a code owner July 8, 2025 11:34
@matthewelwell matthewelwell requested review from emyller and removed request for a team July 8, 2025 11:34
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5108 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5108 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5108 Finished ✅ Results

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@matthewelwell matthewelwell merged commit e9c16e1 into main Jul 8, 2025
56 of 57 checks passed
@matthewelwell matthewelwell deleted the feat/enable-feature-versioning-by-default-for-new-environments branch July 8, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants