Skip to content

feat(BE): release pipeline v0.1.0 #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025
Merged

feat(BE): release pipeline v0.1.0 #5496

merged 4 commits into from
Jul 2, 2025

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented May 27, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add backend code for release pipeline v0.1.0

Related Epic: #5486

How did you test this code?

Add new unit test here and in the private repo

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 7:23am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 7:23am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 7:23am

@github-actions github-actions bot added the api Issue related to the REST API label May 27, 2025
@gagantrivedi gagantrivedi force-pushed the feat/release-pipeline branch 6 times, most recently from e5fab00 to 6b14e39 Compare June 10, 2025 01:28
@gagantrivedi gagantrivedi force-pushed the feat/release-pipeline branch 6 times, most recently from 550f092 to 4909e38 Compare June 17, 2025 08:18
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (0235f18) to head (9fdd219).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5496    +/-   ##
========================================
  Coverage   97.76%   97.77%            
========================================
  Files        1245     1253     +8     
  Lines       44062    44233   +171     
========================================
+ Hits        43076    43247   +171     
  Misses        986      986            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, will need to add test and coverage

@gagantrivedi gagantrivedi force-pushed the feat/release-pipeline branch 4 times, most recently from 9a4242a to 7c4ef9f Compare July 1, 2025 06:43
@gagantrivedi gagantrivedi force-pushed the feat/release-pipeline branch from c773096 to 3be9ede Compare July 1, 2025 07:11
@gagantrivedi gagantrivedi force-pushed the feat/release-pipeline branch 2 times, most recently from b20e53b to 9fdd219 Compare July 1, 2025 07:23
@gagantrivedi gagantrivedi changed the title wip: release pipeline feat: release pipeline v0.1.0 Jul 1, 2025
@gagantrivedi gagantrivedi changed the title feat: release pipeline v0.1.0 feat(BE): release pipeline v0.1.0 Jul 1, 2025
@gagantrivedi gagantrivedi marked this pull request as ready for review July 1, 2025 07:33
@gagantrivedi gagantrivedi requested a review from a team as a code owner July 1, 2025 07:34
@gagantrivedi gagantrivedi requested review from Zaimwa9 and removed request for a team July 1, 2025 07:34
@github-actions github-actions bot added the feature New feature or request label Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5496 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5496 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5496 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5496 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5496 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-5496 Finished ✅ Skipped

Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and been tested over the different frontend reviews.

One UX comment (ordering) if possible to update in private

release_pipelines_views = importlib.import_module("release_pipelines_logic.views")
projects_router.register(
r"release-pipelines",
release_pipelines_views.ReleasePipelineViewSet,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I realized this morning. Right now they are ordered by ASC created at. It might make more sense to have the newest pipelines first in GET list if not too much effort



class PipelineStage(models.Model):
name = models.CharField(max_length=255)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagoapolo, NIT detail for future versions but maybe in the frontend we could warn/block same stage names in a pipeline

@gagantrivedi gagantrivedi merged commit de7c278 into main Jul 2, 2025
50 checks passed
@gagantrivedi gagantrivedi deleted the feat/release-pipeline branch July 2, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants