Skip to content

feat: generate-a-auth-cookie-on-oauth-succesful-logins #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 2, 2025

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jun 30, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Allow Google and Github OAuth with cookie login.

  • Set a cookie when cookie_auth is enabled and oauth succesful

How did you test this code?

  • Manually
  • ⚠️ couldn't test github due to redirect_uri not set for local

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 30, 2025 14:49
@Zaimwa9 Zaimwa9 requested review from emyller and removed request for a team June 30, 2025 14:49
Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:06pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:06pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:06pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5670 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5670 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5670 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5670 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5670 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5670 Finished ✅ Results

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (de7c278) to head (01d50ce).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5670   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1253     1253           
  Lines       44242    44279   +37     
=======================================
+ Hits        43256    43293   +37     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution looks good with a slight re-shaping. Also please add tests to cover the settings.COOKIE_AUTH_ENABLED case. Thanks!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2025
@Zaimwa9 Zaimwa9 requested a review from emyller July 2, 2025 15:05
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2025
@Zaimwa9 Zaimwa9 merged commit 4528877 into main Jul 2, 2025
27 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/support-oauth-with-cookie-auth branch July 2, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants