-
Notifications
You must be signed in to change notification settings - Fork 449
feat: generate-a-auth-cookie-on-oauth-succesful-logins #5670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
for more information, see https://pre-commit.ci
Docker builds report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5670 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1253 1253
Lines 44242 44279 +37
=======================================
+ Hits 43256 43293 +37
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution looks good with a slight re-shaping. Also please add tests to cover the settings.COOKIE_AUTH_ENABLED
case. Thanks!
…smith/flagsmith into feat/support-oauth-with-cookie-auth
…rt-oauth-with-cookie-auth
Co-authored-by: Evandro Myller <[email protected]>
Co-authored-by: Evandro Myller <[email protected]>
Co-authored-by: Evandro Myller <[email protected]>
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Allow Google and Github OAuth with cookie login.
How did you test this code?