Skip to content

ci: Add mypy problem matcher #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

ci: Add mypy problem matcher #5692

merged 4 commits into from
Jul 7, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 2, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This wraps the make typecheck call in CI with a problem matching action, enabling Mypy annotations for the PRs.

How did you test this code?

Tested in CI with a deliberate typing error:
45930

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:16pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:16pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 4:16pm

@khvn26 khvn26 requested a review from a team as a code owner July 2, 2025 15:22
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team July 2, 2025 15:22
@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5692 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5692 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5692 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5692 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5692 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5692 Finished ✅ Results

@github-actions github-actions bot added api Issue related to the REST API ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 2, 2025
@khvn26 khvn26 force-pushed the ci/mypy-problem-matcher branch from 469d893 to f2f4c85 Compare July 2, 2025 16:16
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (de7c278) to head (f2f4c85).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5692   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1253     1253           
  Lines       44242    44242           
=======================================
  Hits        43256    43256           
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit 9d98d71 into main Jul 7, 2025
30 checks passed
@khvn26 khvn26 deleted the ci/mypy-problem-matcher branch July 7, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants