Skip to content

fix: trigger create hubspot user post tracker #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Jul 16, 2025

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jul 4, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

We need the cookie (and utms) before creating the hubspot contact. As it was deferred to the task processor as a user post_create hook, the creation could happen before storing the relevant data.

This PR moved the dispatch after creating the Hubspot tracker

How did you test this code?

  • Added tests

matthewelwell and others added 30 commits June 3, 2025 11:22
…/flagsmith into fix/hubspot-attribution-issues
….com:Flagsmith/flagsmith into fix/trigger-create-hubspot-user-post-tracker
@github-actions github-actions bot added fix and removed fix labels Jul 14, 2025
@Zaimwa9 Zaimwa9 requested a review from emyller July 14, 2025 16:59
@github-actions github-actions bot added fix and removed fix labels Jul 15, 2025
@github-actions github-actions bot added fix and removed fix labels Jul 15, 2025
@github-actions github-actions bot added fix and removed fix labels Jul 15, 2025
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on conversations with @Zaimwa9 and @emyller.

Since all of the feedback from @emyller has been addressed, along with the change to split out the parameterised test, as originally suggested by @Zaimwa9 , the PR has been sufficiently reviewed and improved. Let's merge.

@Zaimwa9 Zaimwa9 requested review from emyller and removed request for tiagoapolo and emyller July 16, 2025 08:48
@Zaimwa9 Zaimwa9 dismissed emyller’s stale review July 16, 2025 08:49

Seen with Matthew

@Zaimwa9 Zaimwa9 merged commit 567ffee into main Jul 16, 2025
29 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/trigger-create-hubspot-user-post-tracker branch July 16, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of asynchronous contact creation in hubspot Create hubspot contact after HubspotTracker
3 participants