Skip to content

fix: Add missing Swagger schema for GET feature by ID #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025

Conversation

rolodato
Copy link
Contributor

@rolodato rolodato commented Jul 7, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Currently, there is no response schema for the "GET feature by ID" endpoint https://api.flagsmith.com/api/v1/docs/#/api/api_v1_projects_features_read

image

This PR adds the correct response schema:

image

How did you test this code?

DEBUG=True python manage.py runserver

then browse to http://127.0.0.1:8000/api/v1/docs/#/api/api_v1_projects_features_read

@rolodato rolodato requested a review from a team as a code owner July 7, 2025 15:19
@rolodato rolodato requested review from khvn26 and removed request for a team July 7, 2025 15:19
Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 0:26am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 0:26am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 0:26am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5713 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5713 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5713 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5713 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5713 Finished ✅ Results

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (1e580e5) to head (77eb346).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5713   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1253     1255    +2     
  Lines       44275    44351   +76     
=======================================
+ Hits        43289    43365   +76     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added fix and removed fix labels Jul 7, 2025
@rolodato rolodato force-pushed the feat/get-feature-by-id-swagger branch from c8e4a2e to 3522264 Compare July 8, 2025 12:18
@github-actions github-actions bot added fix and removed fix labels Jul 8, 2025
@rolodato rolodato force-pushed the feat/get-feature-by-id-swagger branch from 3522264 to e35001a Compare July 8, 2025 12:19
@github-actions github-actions bot added fix and removed fix labels Jul 8, 2025
@rolodato rolodato requested a review from matthewelwell July 8, 2025 12:21
@github-actions github-actions bot added fix and removed fix labels Jul 8, 2025
@rolodato rolodato merged commit d688c09 into main Jul 8, 2025
29 checks passed
@rolodato rolodato deleted the feat/get-feature-by-id-swagger branch July 8, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants