Skip to content

fix: Environments don't preserve feature versioning when cloned #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewelwell
Copy link
Contributor

Changes

This PR resolves an issue found in manual testing (because one of my unit tests had a bug in it 🤦 ) where cloning an environment did not enable v2 versioning, even when the flag was enabled.

How did you test this code?

Updated the buggy unit test...

@matthewelwell matthewelwell requested a review from a team as a code owner July 9, 2025 15:29
@matthewelwell matthewelwell requested review from Zaimwa9 and removed request for a team July 9, 2025 15:29
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2025 4:13pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2025 4:13pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2025 4:13pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5740 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5740 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5740 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5740 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5740 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5740 Finished ✅ Results

@khvn26 khvn26 changed the title feat: ensure clone environment handles v2 versioning flag fix: Environments don't preserve feature versioning when cloned Jul 9, 2025
@github-actions github-actions bot added fix and removed feature New feature or request labels Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (d688c09) to head (708c23e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5740   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1255     1255           
  Lines       44351    44357    +6     
=======================================
+ Hits        43365    43371    +6     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell matthewelwell merged commit bca7ed1 into main Jul 9, 2025
29 checks passed
@matthewelwell matthewelwell deleted the fix/ensure-clone-environment-handles-v2-versioning-flag branch July 9, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants