refactor: only clone latest feature states #5743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5743 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1255 1255
Lines 44357 44359 +2
=======================================
+ Hits 43371 43373 +2
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
reviewed
Jul 10, 2025
…ment / feature combination
matthewelwell
requested review from
Zaimwa9 and
khvn26
and removed request for
a team
Docker builds report
|
khvn26
reviewed
Jul 10, 2025
khvn26
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the behaviour when cloning an environment. Previously, the logic would create a clone of all feature states, including old versions, feature states associated with uncommitted change requests, etc. This PR updates the logic to only clone the latest feature states, and mark them as live from the moment the environment is created.
This does change the user experience, but only really for those using v2 versioning (which is currently very few customers), in that they will no longer see a history of changes in the new environment. In my opinion, it was odd behaviour to show the history from another environment in the new environment anyway, so I think this is an improvement.
Refactor environment clone functionality to only clone the latest feature states. This will optimise the logic to speed it up reduce the impact of cloning environments on the database. I've also included some additional DB optimisations using select and prefetch related where necessary.
Note that this also fixes a bug in the logic for enabling versioning on new environments which existed because we were previously using the
enable_v2_versioningtask to create the versions, but this expected the input environment to not have versioning enabled.How did you test this code?
Existing tests should cover the refactor. Updated an existing test with better assertions to verify the bug fix, and new logic.