-
Notifications
You must be signed in to change notification settings - Fork 448
feat: improve last login data #5745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
for more information, see https://pre-commit.ci
…lagsmith into feat/improve-last-login-data
frontend/web/components/users-permissions/OrganisationUsersTable/components/LastLogin.tsx
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5745 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1255 1255
Lines 44357 44386 +29
=======================================
+ Hits 43371 43400 +29
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, having read the backend test, I have one request now.
…ve-last-login-data
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Solves #2183
last_login was natively updated by DRF only during authentication. However we persist session for multiple weeks leading to incorrect data.
This PR aims to update last-login on
GET /me
(once per session in a ideal world) with a 10min buffer. This could be multiple hours as we only showToday
in the dashboard.Additionally:
We used to show
Never | within 30 days | with {xx} days if > 30
=> Allowed to addToday
Yesterday
and number of days within 30 days (7 days ago
e.g).How did you test this code?