Skip to content

chore: add organisation name to traits when identifying organisation in FoF #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jul 15, 2025

Changes

Added organisation name to organisation-related traits

How did you test this code?

Modified existing unit tests to reflect new traits

…gsmith on Flagsmith and rename organisation_id trait to organisation.name
Copy link

sentry-io bot commented Jul 15, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/environments/models.py

Function Unhandled Issue
enable_v2_versioning FlagsmithIntegrationError: Must either use offline mode, or provide FLAGSMITH_ON_FLAGSMITH_SERVER_KEY and FLAGSMITH_ON_FLAGSMITH_SERVER_API_URL. ...
Event Count: 8
enable_v2_versioning FlagsmithIntegrationError: Must either use offline mode, or provide FLAGSMITH_ON_FLAGSMITH_SERVER_KEY and FLAGSMITH_ON_FLAGSMITH_SERVER_API_URL. ...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the api Issue related to the REST API label Jul 15, 2025
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 11:42am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 11:42am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 11:42am

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (4f703a1) to head (6566bd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5752   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1255     1255           
  Lines       44359    44363    +4     
=======================================
+ Hits        43373    43377    +4     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the chore label Jul 15, 2025
@khvn26 khvn26 marked this pull request as ready for review July 15, 2025 11:42
@khvn26 khvn26 requested a review from a team as a code owner July 15, 2025 11:42
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team July 15, 2025 11:42
@github-actions github-actions bot added chore and removed chore labels Jul 15, 2025
Copy link
Contributor

github-actions bot commented Jul 15, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5752 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5752 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5752 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5752 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5752 Finished ✅ Results

@khvn26 khvn26 requested review from Zaimwa9 and removed request for Zaimwa9 July 15, 2025 11:52
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good

@khvn26 khvn26 merged commit 453004b into main Jul 15, 2025
44 checks passed
@khvn26 khvn26 deleted the chore/add-org-name-to-flagsmith-api-traits branch July 15, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants