-
Notifications
You must be signed in to change notification settings - Fork 448
chore: add organisation name to traits when identifying organisation in FoF #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…gsmith on Flagsmith and rename organisation_id trait to organisation.name
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/environments/models.py
Did you find this useful? React with a 👍 or 👎 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5752 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1255 1255
Lines 44359 44363 +4
=======================================
+ Hits 43373 43377 +4
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Docker builds report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks good
Changes
Added organisation name to organisation-related traits
How did you test this code?
Modified existing unit tests to reflect new traits