Skip to content

chore: Move SegmentSerializer back to core API #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emyller
Copy link
Contributor

@emyller emyller commented Jul 16, 2025

Contributes to #5769.

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Move SegmentSerializer, RuleSerializer, and ConditionSerializer back to the core API code. They were moved in the past, and have since evolved.
  • Delete custom logic to handle nested objects in favor of WritableNestedModelSerializer.

How did you test this code?

Replaced an organ, patient walked out smiling with no tests failing.

  • Double check test coverage.

@emyller emyller self-assigned this Jul 16, 2025
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 16, 2025 10:29pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jul 16, 2025 10:29pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jul 16, 2025 10:29pm

@github-actions github-actions bot added api Issue related to the REST API chore labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant