Enhance Tags on TrailCard component with toggle support #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
trail_card.sveltto show only first 2 tags by defaultchip.sveltWhy this is useful
trail_card.sveltto remain visual without taking away from the cover photo by using the tag optionsScreenshots
Before
After
Explanation
I like the use of adding tags to the trails but they take up a lot of space on the trail card view, taking away from the visual images of each trail. I made it so by default it will show the first 2 tags and show "+[x] more" which is a toggle allowing the user to expand the remaining tags if they choose to do so. I also made the text smaller "text-xs" on the
chip.sveltto help with the visuals.