-
Notifications
You must be signed in to change notification settings - Fork 70
chore: Update URLs to the Device Agent Installer download scripts #5849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5849 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 369 369
Lines 17834 17834
Branches 4155 4155
=======================================
Hits 13746 13746
Misses 4088 4088
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But not merging until we can check pre-reqs are met in the morning
Both scripts are now available on GH Pages for the |
may not be important but spotted one difference in behavior between the old url and the new one. The old url would open the script as text in the brwoser while the new one would download the file. Can it have an impact on the intstaller? |
Using the pre-staging environment for this PR with new URLs to |
Description
Caution
This pull request should be merged only once download scripts are publicly available
This pull request changes URLs to the Device Agent Installer 'get' scripts to ones hosted on the GitHub Pages.
Related Issue(s)
FlowFuse/device-agent#442
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label