Skip to content

chore: Update URLs to the Device Agent Installer download scripts #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jul 30, 2025

Description

Caution

This pull request should be merged only once download scripts are publicly available

This pull request changes URLs to the Device Agent Installer 'get' scripts to ones hosted on the GitHub Pages.

Related Issue(s)

FlowFuse/device-agent#442

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested review from cstns and hardillb July 30, 2025 19:24
@ppawlowski ppawlowski marked this pull request as ready for review July 30, 2025 19:24
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.07%. Comparing base (06f9c4a) to head (d5e82d4).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5849   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         369      369           
  Lines       17834    17834           
  Branches     4155     4155           
=======================================
  Hits        13746    13746           
  Misses       4088     4088           
Flag Coverage Δ
backend 77.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not merging until we can check pre-reqs are met in the morning

@ppawlowski
Copy link
Contributor Author

But not merging until we can check pre-reqs are met in the morning

Both scripts are now available on GH Pages for the device-agent repo. IMO, it is ok to merge this PR.

@cstns
Copy link
Contributor

cstns commented Jul 31, 2025

may not be important but spotted one difference in behavior between the old url and the new one. The old url would open the script as text in the brwoser while the new one would download the file. Can it have an impact on the intstaller?

@ppawlowski
Copy link
Contributor Author

ppawlowski commented Jul 31, 2025

may not be important but spotted one difference in behavior between the old url and the new one. The old url would open the script as text in the brwoser while the new one would download the file. Can it have an impact on the intstaller?

Using the pre-staging environment for this PR with new URLs to get scripts, I was able to install device agents on all supported operating systems.

@ppawlowski ppawlowski merged commit 6a59980 into main Jul 31, 2025
23 checks passed
@ppawlowski ppawlowski deleted the chore-update-dai-links branch July 31, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants