Skip to content

Do not fall through to error case after successful SAML login #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

knolleary
Copy link
Member

Fixes #5856

Adds a missing return to avoid falling through to logging an invalid error.

@knolleary knolleary requested a review from hardillb August 1, 2025 10:04
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.48%. Comparing base (55c639b) to head (17f4792).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/sso/auth.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5857      +/-   ##
==========================================
- Coverage   76.49%   76.48%   -0.01%     
==========================================
  Files         369      369              
  Lines       17969    17970       +1     
  Branches     4189     4189              
==========================================
  Hits        13745    13745              
- Misses       4224     4225       +1     
Flag Coverage Δ
backend 76.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb hardillb merged commit a175185 into main Aug 1, 2025
20 checks passed
@hardillb hardillb deleted the 5856-fix-saml-log branch August 1, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error message in log after SAML login with group asserts
2 participants