fix(demo): improve dark theme support in demos

[javier-godoy]

Summary by CodeRabbit

• Refactor

  • Updated theme change handling in demo classes to use a centralized method from TabbedDemo
  • Simplified theme application logic across multiple demo classes

• Chores

  • Added new import for TabbedDemo in demo classes

[coderabbitai]

Walkthrough

The pull request involves modifications to two demo classes within the ExtendedLogin addon: ExtendedLoginOverlayDemo and LoginLayoutDemo. In both classes, the onThemeChange method has been updated to replace direct JavaScript theme application with a call to a static applyTheme method from the TabbedDemo class. This change standardizes the theme application approach across demo classes, introducing a centralized method for handling theme changes.

Changes

File	Change Summary
src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java	- Added import for TabbedDemo - Replaced direct JavaScript theme setting with TabbedDemo.applyTheme() method call
src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java	- Added import for TabbedDemo - Replaced direct JavaScript theme setting with TabbedDemo.applyTheme() method call

Possibly related PRs

• fix(demo): improve dark theme support in demos #16: Similar theme handling modification in LoginLayoutDemo class, indicating a consistent approach to theme changes across demo components

Suggested reviewers

• mlopezFC
• paodb

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27d80aa and 6c25694.

📒 Files selected for processing (2)

• src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java (2 hunks)
• src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java (2 hunks)

🔇 Additional comments (4)

src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java (2)

23-23: LGTM!

The import statement aligns with the new theme application approach.

---

49-49: Verify the TabbedDemo.applyTheme implementation.

The change improves code maintainability by centralizing theme application logic. However, let's verify the implementation of TabbedDemo.applyTheme to ensure it handles theme changes correctly.

src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java (2)

23-23: LGTM!

Clean addition of the TabbedDemo import, following the existing import organization pattern.

---

50-50: Verify the TabbedDemo.applyTheme implementation.

The change improves code organization by centralizing theme application logic. However, let's verify the implementation of the new method.

✅ Verification successful

TabbedDemo.applyTheme usage is consistent and correct

The method is part of the demo framework's public API (com.flowingcode.vaadin.addons.demo.TabbedDemo) and is used consistently across demo classes implementing ThemeChangeObserver.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementation of TabbedDemo.applyTheme
# Expected: Find the method implementation and its usage across demo classes

# Search for the applyTheme method implementation
echo "Searching for TabbedDemo.applyTheme implementation:"
ast-grep --pattern 'class TabbedDemo {
  $$$
  static $_ applyTheme($_) {
    $$$
  }
  $$$
}'

# Search for other usages to verify consistent implementation
echo -e "\nSearching for other usages of TabbedDemo.applyTheme:"
rg "TabbedDemo\.applyTheme" -A 2

Length of output: 997

---

Script:

#!/bin/bash
# Find TabbedDemo.java file
echo "Searching for TabbedDemo.java:"
fd TabbedDemo.java

# Try to find the class implementation with a broader pattern
echo -e "\nSearching for TabbedDemo class implementation:"
rg "class TabbedDemo" -A 10

# Look for any method containing 'applyTheme'
echo -e "\nSearching for applyTheme method:"
ast-grep --pattern 'static $_ applyTheme($$$)'

Length of output: 360

---

Script:

#!/bin/bash
# Check imports in files using TabbedDemo
echo "Checking imports in LoginLayoutDemo.java:"
rg "^import.*TabbedDemo" src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java

echo -e "\nChecking imports in ExtendedLoginOverlayDemo.java:"
rg "^import.*TabbedDemo" src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java

# Broader search for TabbedDemo in any file
echo -e "\nSearching for any file containing TabbedDemo:"
rg -l "TabbedDemo"

# Look for base demo classes
echo -e "\nSearching for potential base demo classes:"
fd -e java . src/test | xargs rg "class.*Demo.*extends"

Length of output: 1812

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud