Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register iconset when vaadin-iconset is defined #106

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

javier-godoy
Copy link
Member

I'm not sure if this is a fix to #105, but certainly it doesn't harm.

+customElements.whenDefined('vaadin-iconset').then(Iconset=>{
Iconset.register('fas', 1000, template);

const iconset = Iconset.getIconset('fas');

for (const name in aliases) {
    iconset._icons[name] = iconset._icons[aliases[name]];
}
+});

@javier-godoy javier-godoy requested review from mlopezFC and paodb April 24, 2024 19:38
Copy link
Member

@paodb paodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 99ad284 into master Apr 30, 2024
2 checks passed
@paodb paodb deleted the fix-20240424 branch April 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants