Skip to content

Fix for add polygon feature not rendering as expected #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Conversation

paodb
Copy link
Member

@paodb paodb commented May 30, 2025

This PR includes a fix for #152. The fix includes web-component version update to 3.8.2.

The new web-component version also contains a fix for the console logged error mentioned in #153.

Summary by CodeRabbit

  • Chores

    • Updated the Google Maps component dependency to version 3.8.2 for improved compatibility and stability.
  • New Features

    • The map now explicitly sets the "slot" attribute for certain elements, enhancing integration with other components.

This version includes a partial fix for #152.
@paodb paodb requested review from javier-godoy and mlopezFC May 30, 2025 18:25
Copy link

coderabbitai bot commented May 30, 2025

"""

Walkthrough

This change updates the @flowingcode/google-map NPM package dependency from version 3.8.1 to 3.8.2 in several Java classes. Additionally, the constructor of GoogleMapPoly now explicitly sets the element's "slot" attribute to "objects". No other logic or public API changes were made.

Changes

Files Change Summary
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java
Updated @NpmPackage annotation for @flowingcode/google-map from version 3.8.1 to 3.8.2
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java Updated @NpmPackage annotation to 3.8.2 and set element's "slot" attribute to "objects" in constructor

Possibly related PRs

Suggested reviewers

  • mlopezFC
    """

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9971b1a and 757cc88.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This avoids polys not being shown when created after map initialization.

Close #152
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@javier-godoy
Copy link
Member

Sonar warnings are unrelated to code contributed in this PR.

@javier-godoy javier-godoy merged commit 3a6abd7 into master May 30, 2025
5 of 6 checks passed
@javier-godoy javier-godoy deleted the issue-152 branch May 30, 2025 18:34
@paodb paodb moved this from To Do to Pending release in Flowing Code Addons May 30, 2025
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants