Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark dropout_mask as non-differentiable #1870

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Conversation

ToucheSir
Copy link
Member

Should allow for nested AD of Dropout.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
    - [ ] Documentation, if applicable

Copy link
Member Author

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix a test and add news, a couple comments while I do:

src/layers/normalise.jl Show resolved Hide resolved
test/layers/normalisation.jl Outdated Show resolved Hide resolved
@ToucheSir ToucheSir force-pushed the bc/nondiff_dropout_mask branch from e0f6c9d to deea76a Compare February 13, 2022 02:52
@codecov-commenter
Copy link

Codecov Report

Merging #1870 (5cf7d2f) into master (0b7e1b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files          21       21           
  Lines        1486     1486           
=======================================
  Hits         1257     1257           
  Misses        229      229           
Impacted Files Coverage Δ
src/layers/normalise.jl 83.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7e1b6...5cf7d2f. Read the comment docs.

@ToucheSir ToucheSir merged commit 3cc9067 into master Feb 13, 2022
@ToucheSir ToucheSir deleted the bc/nondiff_dropout_mask branch February 13, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants