Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove some duplicate include" #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ToucheSir
Copy link
Member

Reverts #223 per #223 (comment).

Changes to re-introduce:

  • Updated gitignore
  • rm Publish.jl config in Project.toml
  • rm duplicate includes
  • dropblock([rng = default_rng_value(x)], ... -> dropblock([rng], ...

@CarloLucibello
Copy link
Member

what is the change that doesn't make sense? can we revert only that?

@ToucheSir
Copy link
Member Author

Everything not in the above list. I'm fine with either way, but figured this would be faster since there are other PRs almost ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants