[RUIN] mrege branch; Feature/session and image overlay #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DokySp
commented
Sep 14, 2025
DokySp
commented
- [Issue] Phase 3
- [Descriptions]
- Phase 3 작업내용 Merge
- https://github.com/FoKE-Developers/FourCutTogether/milestone/4?closed=1
- 기존에 단순하게 세션 키만 담고 있었음 - 세션 키, 화면 상태, 프레임 정보 및 상태 정보를 담도록 변경
- 기존 frame들을 default로 묶어서 분리 - 추후 여러 frame set이 생길 수도 있으므로 위와같이 분리
- select image 에 신규 Cut Frame 타입 적용
- 이미지 비율 및 ViewPager 일부 수정
- 한장 및 두장 생성 구조 추가 - 카메라가 없을 시, 테스트가 가능하도록 설정 추가 - GraphicsLayer에서 bitmap을 뽑아내는데 Compose와 타이밍 이슈가 있음. 추후 해결 필요.
…evelopers#41] - 이미지 오버레이 추가 - 실테스트 후 일부 수치 조정
- 날짜 표기 옵션 추가
- 컷 표기 한글로 변경 - 컷 일부 디자인 변경 - SelectFrameScreen 디자인 일부 변경
- 추후 커밋 나눠서 다시 해보기
- 파일 자동 저장 기능 추가
ing03201
reviewed
Sep 14, 2025
domain/src/main/java/com/foke/together/domain/interactor/entity/CutFrameType.kt
Show resolved
Hide resolved
ing03201
previously approved these changes
Sep 14, 2025
ing03201
approved these changes
Sep 14, 2025
ing03201
approved these changes
Sep 15, 2025
ing03201
approved these changes
Sep 15, 2025
fetiu
approved these changes
Sep 15, 2025
DokySp
changed the title
DokySp
added a commit
that referenced
this pull request
Sep 17, 2025
- **[Issue]** Phase 3 - **[Descriptions]** - Phase 3 작업내용 Merge - https://github.com/FoKE-Developers/FourCutTogether/milestone/4?closed=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.